Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few more minor improvements #1788

Merged
merged 5 commits into from
Nov 28, 2023

Conversation

ptomato
Copy link
Contributor

@ptomato ptomato commented Sep 23, 2023

Description

These are a few more minor improvements that were sitting around in my branches, so as I'm cleaning up the branches I've split them out to submit them.

Related Pull Requests

None.

Does your pull request have unit tests

No change to features, so no tests necessary.

These sources are already compiled into the V8 artifacts, and are not
compiled as part of the runtime.
This line shadows a v8::Context already present in the outer scope, so
it's not necessary.
…cient

Two changes suggested by Android Studio. We avoid copying the string
argument, and we check quicker whether the map is empty without having to
count all the entries.
JSWrapperConstructorCallback isn't used anywhere.
Noticed while fixing static initialization of keywords set, see next
commit.
@cla-bot cla-bot bot added the cla: yes label Sep 23, 2023
@edusperoni edusperoni merged commit 25338bf into NativeScript:v8-v11 Nov 28, 2023
2 checks passed
@ptomato ptomato deleted the remaining-minor-fixes branch November 28, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants